-
Notifications
You must be signed in to change notification settings - Fork 300
Added logarithmic anomaly contouring example. #1048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I haven't looked at this in detail, but given the similarity to #1040 I suggest bringing some of the latest changes from that one into this PR. |
Done -- see pp-mo@889836e. |
|
Now rebased to include merged code from #1040. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice to be consistent and symmetric with the use of the decimal point, i.e. one of:
[-3.0, -1.0, -0.3, -0.1, 0.1, 0.3, 1.0, 3.0],[-3, -1, -0.3, -0.1, 0.1, 0.3, 1, 3],- or perhaps even
[-3, -1, -.3, -.1, .1, .3, 1, 3].
|
Thanks @pp-mo - I like it. 👍 Once we've discussed the two minor points I've raised above I'll be happy to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads like the "similar cases" are logarithmic scaling, but you are referring to linear colour scaling aren't you? I don't think it reads well. You should be specific about this e.g.:
For linear colour scaling it is perfectly practical to select a suitable colormap and allow
contour to pick the level colours automatically from that, provided that the data range is
symmetric about zero, and that the colormap is diverging (see the 'Diverging colormaps'
section in: `<http://matplotlib.org/examples/color/colormaps_reference.html>`_).
Something along these lines?
|
@pp-mo - I've made several comments on writing style. For each I provided an alternative wording, please take this as an example of what I mean rather than an instruction to use it as a direct replacement for your wording. |
|
@LukeC92 thanks, on reviewing this I think I'm happy to close. |
Looks like another version of #1040, but actually rather more different than similar.
TODO: