Outstanding review issues from #3096 (gridcell rotations) #3114
Description
Premature merge.
Outstanding comments :
- lots of stickler complaints
- Gridcell rotations #3096 (review)
- maybe reconsider Gridcell rotations #3096 (comment)
- ? Gridcell rotations #3096 (comment)
- ? consider : combine with other code for 3d latlon/xyz transform ? Gridcell rotations #3096 (comment)
- inherited + other comments to clarify
- should remove make-discontiguous routine : see Pin Dask to avoid 0.18.2 bug with masked arrays. #3127 (comment)
Missing test aspects : originally from #3103
CODE CHANGES
angles routine should handle non-2d coords with meshgrid- Too tricky : ABANDONED ? but this reduces the generality of "rotate_grid_angles"
ANGLES TEST ASPECTS : testing of 'grid_angles'
- THINK THIS IS ALL NOW COVERED BY Vector plots 2 #3120 (check when that is accepted)
- (cube)
- unrecognised inputs (no shapes)
- missing y + x not cube
- coords
- not 2d : (support?)
- different shapes : error
(except 1d?) - different cube dims
(2d : ok for 1d) - different cs : error
- no cs, but not angles, i.e. plain X+Y coords : ??
- X/Y = coord/not, and not/coord
- cell_angle_boundpoints unrecognised
ROTATE TEST ASPECTS : testing of 'rotate_grid_vectors'
- u+v
- u+v with angles supplied
- u+v with angles derived from u
- angles method key
- check that magnitudes remain unchanged
- check actual angles-rotation calculation (known vector + angles)
check that non-2d cubes work(not supported now ?)- check masking of invalid points
- check behaviour with 0-vectors ?
- Exceptions:
- angles not angular (bad unit)
- u+v not same shape (implied by arithmetic)
- angles not same dims as u+v (implied by arithmetic)
- ?possibly~ : NaN angles handling ?