Fix for backwards-incompatible change in iris.fileformats.rules.Loader #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling e94b852 on pp-mo:loader_fix into ** on SciTools:master**. |
pelson
approved these changes
Oct 19, 2017
Member
pelson
left a comment
pelson
left a comment
There was a problem hiding this comment.
Where does this PR sit. Does it need merging? If so 👍
Member
Author
In principle this change will be needed. |
Member
Author
|
This commit now subsumed in #87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix, just to prove recent merge is o.k.
It may not be worth much to merge this, as https://github.com/SciTools/iris/tree/dask_mask_array is coming soon ...