-
Notifications
You must be signed in to change notification settings - Fork 44
Converted test_pickle_message to pytest, and removed reliance on Iris #620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
64 changes: 0 additions & 64 deletions
64
src/iris_grib/tests/integration/iris_integration/test_pickle_message.py
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # Copyright iris-grib contributors | ||
| # | ||
| # This file is part of iris-grib and is released under the BSD license. | ||
| # See LICENSE in the root of the repository for full licensing details. | ||
| """Check that a GribMessage can be pickled.""" | ||
|
|
||
| # Import iris_grib.tests first so that some things can be initialised before | ||
| # importing anything else. | ||
| import iris_grib.tests as tests | ||
|
|
||
| import pickle | ||
|
|
||
| import pytest | ||
| from iris_grib.message import GribMessage | ||
|
|
||
| MIN_PICKLE_PROTOCOL = 4 | ||
|
|
||
| TESTED_PROTOCOLS = list(range(MIN_PICKLE_PROTOCOL, pickle.HIGHEST_PROTOCOL + 1)) | ||
|
|
||
|
|
||
| @tests.skip_data | ||
| class TestPickleGribMessage: | ||
| @pytest.fixture | ||
| def messages(self): | ||
| path = tests.get_data_path(("GRIB", "fp_units", "hours.grib2")) | ||
| return GribMessage.messages_from_filename(path) | ||
|
|
||
| def pickle_obj(self, obj, protocol, tmp_path): | ||
| # NOTE: Neither GribMessage, nor its lazy ".data", read back from | ||
| # a pickled obj. Currently, this only checks that they can be pickled | ||
| # successfully. | ||
| filename = tmp_path / ".pkl" | ||
| with open(filename, "wb") as f: | ||
| pickle.dump(obj, f, protocol) | ||
| # TODO: resolve this or remove the test. | ||
| # with open(filename, "rb") as f: | ||
| # nobj = pickle.load(f) | ||
| # assert nobj == obj | ||
|
|
||
| @pytest.mark.parametrize("protocol", TESTED_PROTOCOLS) | ||
| def test_message(self, protocol, messages, tmp_path): | ||
| obj = next(messages) | ||
| self.pickle_obj(obj, protocol, tmp_path) | ||
|
|
||
| @pytest.mark.parametrize("protocol", TESTED_PROTOCOLS) | ||
| def test_message_data(self, protocol, messages, tmp_path): | ||
| obj = next(messages).data | ||
| self.pickle_obj(obj, protocol, tmp_path) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.