Closed
Conversation
Member
Author
|
Outstanding Questions :
|
Member
Author
|
Added 2 new commits to fix for recent changes in Iris : Notably from SciTools/iris#3804, which has rationalised types of coordinate-system properties (most are now cast to floats) This tested all passed with this recent Iris commit |
Member
Author
|
Now done in #231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: DO NOT MERGE
until we have Iris3, and this is re-tested + OK
Closes #207
These changes will be needed when we release the changes on iris default_units feature-branch
(but which is not yet merged, hence WIP flag).
They just ensure "units=1", for unchanged behaviour when creating coords.
That is anyway benign : it all works with current Iris.
( checked out locally, against the Iris feature-branch current content )