Port tests from iris/tests/test_uri_ccallback.py #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2020
pp-mo
reviewed
Feb 21, 2020
Member
pp-mo
left a comment
pp-mo
left a comment
There was a problem hiding this comment.
I have some problems with this, but I agree we want minimal changes for now, so I'll merge this + maybe propose some simplification
| ) | ||
| ) | ||
| else: | ||
| # Old-style loader provides 'GribWrapper' type field. |
Member
There was a problem hiding this comment.
This part is completely redundant, as we don't use this thing anywhere else and we aren't doing callback testing on GRIB1. So, we don't even need the hasattr(field, "sections").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure where to put this type of test.
I have created a new directory for integration tests specifically relating to Iris functionality, but I'm open to other suggestions!
Companion PR: SciTools/iris#3665