Port tests from iris/tests/integration/test_grib2.py #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 20, 2020
Member
Author
|
GRIB saving with eccodes 2.16 seems to be broken as is causing the tests to fail. I suggest we pin back to eccodes 2.14 #193. |
lbdreyer
commented
Feb 20, 2020
| self.assertEqual(cube.ndim, 3) | ||
| self.assertEqual(cube.coord_dims("time"), (0,)) | ||
| cube = cube[0] | ||
|
|
Member
Author
There was a problem hiding this comment.
This cube loads in with a shape of (928, 744).
6 years ago, eccodes had a bug such that it could only save square data. Thus, in Iris this tests square off the data before saving it (see here). I have removed that as the bug has been fixed (many years ago!)
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion Iris PR: SciTools/iris#3664