Skip to content

Conversation

@lbdreyer
Copy link
Member

@lbdreyer lbdreyer commented Dec 3, 2019

I wrote up a summary of what changed in the 0.15 release.

The question is, does this go in before or after we cut the 0.15 release?

@lbdreyer lbdreyer added this to the v0.15 milestone Dec 3, 2019
@lbdreyer lbdreyer requested a review from pp-mo December 3, 2019 17:05
@coveralls
Copy link

coveralls commented Dec 3, 2019

Coverage Status

Coverage increased (+0.4%) to 86.777% when pulling be30bfb on lbdreyer:release_notes into 2cf099a on SciTools:master.


* Cubes loaded from GRIB files now contain a new GRIB_PARAM attribute, the
value of which is an instance of
iris_grib.grib_phenom_translation.GRIBCode and represents the parameter code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's worth mentioning the effect on saving here, too.

@pp-mo
Copy link
Member

pp-mo commented Dec 4, 2019

does this go in before or after we cut the 0.15 release?

before, I should say.

@pp-mo
Copy link
Member

pp-mo commented Dec 4, 2019

Hi @lbdreyer.
A few suggestions : see what you think.
Otherwise I think this is all good. 👍

@lbdreyer
Copy link
Member Author

lbdreyer commented Dec 4, 2019

@pp-mo
I have addressed your outstanding PR review comments. I think this is good to go?

Also note, the test in iris that were testing iris-grib functionality but were being skipped are unskipped in SciTools/iris#3582

So once this PR is in I think we are ready to cut the release (and v0.15.x branch I suppose)

@pp-mo
Copy link
Member

pp-mo commented Dec 5, 2019

Thanks @lbdreyer , looks good to me.

@pp-mo pp-mo merged commit d5da26c into SciTools:master Dec 5, 2019
@lbdreyer lbdreyer deleted the release_notes branch June 27, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants