-
Notifications
You must be signed in to change notification settings - Fork 18
Remove flake8 and black Nox sessions. #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 28 28
Lines 2829 2829
=======================================
Hits 2811 2811
Misses 18 18 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
stephenworsley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe black and flake should now not be needed in the requirements files. They are absent from the Iris requirements (removed with this PR SciTools/iris#4181).
Otherwise this looks good.
Good catch, thanks |
|
Looks like the pre-commit config is missing the appropriate subcommands to mimic what was happening in the Nox session. Will look later. |
stephenworsley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
In line with Iris, this PR proposes relying purely on pre-commit.ci (already enabled on this repo) for linting tasks, doing away with independently managed Nox sessions.
This reduces duplication, and removes the risk of divergence between the Nox sessions and the pre-commit setup (which recently caused this CI failure - different linter versions were insisting on different standards).
Iris' decision-making history:
drop black and flake8 dependencies iris#4181
adopt ci gha iris#4503