Skip to content

Conversation

@trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Feb 8, 2023

In line with Iris, this PR proposes relying purely on pre-commit.ci (already enabled on this repo) for linting tasks, doing away with independently managed Nox sessions.

This reduces duplication, and removes the risk of divergence between the Nox sessions and the pre-commit setup (which recently caused this CI failure - different linter versions were insisting on different standards).

Iris' decision-making history:

@trexfeathers trexfeathers changed the title Removed flake8 and black Nox sessions. Remove flake8 and black Nox sessions. Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #236 (01bfcdb) into main (dbd1cb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #236   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          28       28           
  Lines        2829     2829           
=======================================
  Hits         2811     2811           
  Misses         18       18           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe black and flake should now not be needed in the requirements files. They are absent from the Iris requirements (removed with this PR SciTools/iris#4181).

Otherwise this looks good.

@trexfeathers
Copy link
Contributor Author

I believe black and flake should now not be needed in the requirements files. They are absent from the Iris requirements (removed with this PR SciTools/iris#4181).

Good catch, thanks

@trexfeathers
Copy link
Contributor Author

Looks like the pre-commit config is missing the appropriate subcommands to mimic what was happening in the Nox session. Will look later.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@stephenworsley stephenworsley merged commit 4107305 into SciTools:main Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants