Use more stable version of connectivity indices#144
Merged
trexfeathers merged 7 commits intoSciTools:unstructured_schemefrom Jan 27, 2022
Merged
Conversation
Contributor
Codecov Report
@@ Coverage Diff @@
## unstructured_scheme #144 +/- ##
====================================================
Coverage 99.54% 99.54%
====================================================
Files 27 27
Lines 1767 1767
====================================================
Hits 1759 1759
Misses 8 8
Continue to review full report at Codecov.
|
trexfeathers
approved these changes
Jan 27, 2022
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
I'm merging including the benchmark failure, which we've determined is statistical noise (need to think more about sensitivity).
Merged
stephenworsley
added a commit
to stephenworsley/iris-esmf-regrid
that referenced
this pull request
Jan 31, 2022
* unstructured_scheme: (24 commits) reset flag (SciTools#145) Use more stable version of connectivity indices (SciTools#144) Check mesh equality on MeshToGridESMFRegridder call (SciTools#138) Formalise regridder file format (SciTools#137) Fix issue 135 (mesh to grid chunking problems) (SciTools#136) Add load/save benchmarks (SciTools#132) Regridder load/saving (SciTools#130) Update dependencies (SciTools#128) Perform scalability for larger grids (SciTools#122) Add performance tests (SciTools#117) change iris source (SciTools#115) Unstructured scheme lazy regridding (with performance tests) (SciTools#111) Updating feature branch unstructured_scheme from 44d6048 to head of main, e528cbf Add grid to mesh scheme (SciTools#96) Unstructured scheme integration test (SciTools#66) Updated lockfiles according to branch requirement spec. Update Version to v0.1.dev2 (SciTools#59) Update version to v0.1.dev1 (SciTools#58) Unstructured Scheme - Extra Dims (SciTools#55) add __init__ to tests (SciTools#56) ... # Conflicts: # benchmarks/benchmarks/ci/esmf_regridder.py # benchmarks/benchmarks/generate_data.py # requirements/nox.lock/py36-linux-64.lock # requirements/nox.lock/py37-linux-64.lock # requirements/nox.lock/py38-linux-64.lock # requirements/py36.yml # requirements/py37.yml
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
indices_by_location()ensures that regridding still works in the case whereface_node_connectivity.location_axis= 1.