-
Notifications
You must be signed in to change notification settings - Fork 21
Fix CI #247
Fix CI #247
Conversation
| language: generic | ||
|
|
||
| os: | ||
| # - linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed all the unused parts to make this cleaner.
| # Only run the upload if the binstar token is present. | ||
| - export UPLOAD_CHANNELS=$(if [ -z ${BINSTAR_TOKEN+x} ]; then echo ""; else echo "--upload-channels scitools/label/${LABEL_NAME}"; fi) | ||
| - curl -L -O https://raw.githubusercontent.com/conda-forge/conda-smithy/master/bootstrap-obvious-ci-and-miniconda.py | ||
| - python bootstrap-obvious-ci-and-miniconda.py ~/miniconda x64 3 --without-obvci && source ~/miniconda/bin/activate root |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CIs no longer depend on obvious-ci.
|
|
||
| - conda install --yes -c conda-forge conda-build-all | ||
| # https://github.com/SciTools/conda-build-all/issues/79 | ||
| - conda install --yes conda==4.2.16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot use conda >=4.3 with conda-build-all. See conda-tools/conda-build-all#79
| PY_CONDITION: "python >=3.4,<3.5" | ||
| - TARGET_ARCH: "x64" | ||
| CONDA_PY: "35" | ||
| CONDA_INSTALL_LOCN: C:\\Miniconda35 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am "spelling out" the local installation of miniconda on AppVeyor to make the CI a little bit faster. But note that AppVeyor does not have miniconda for Python 3.4, so that will start with Python 3.5 and will be a little bit slower b/c conda-build will download 3.4 from there.
|
@ocefpaf this is brilliant brilliant stuff 💯 I'm only sad I don't have time to look at it properly now! Thanks for taking time to fix poor broken SciTools 😄 |
Some people in my work group is still reluctant to get packages from I would love for you guys to shut this channel down and/or start endorsing |
We might just have some news to share in that area soon ㊙️ |
We have worked on this approach as a preferred option, and as of this morning, this is now the case. https://github.com/SciTools/iris/blob/master/INSTALL http://scitools.org.uk/iris/docs/latest/installing.html my preference is to cease work on this repository and concentrate effort on conda-forge from now Do you think this is a sensible apporach? would you still like to see this PR merged? |
|
Those are awesome news. It will help to clarify a lot of confusion.
Is it weird if I say yes to both? I don't the latest iris was ever released in the scitools channel and this would help the transition. |
|
Closed due to the deprecation of this repo. #250 |
Alternative to #243
I tried to simplify the CI configuration as much as I could and them back in order. Hopefully this PR is OK.