Skip to content
This repository was archived by the owner on Dec 4, 2018. It is now read-only.

Update iris recipe for Iris v1.12.0 release#244

Closed
djkirkham wants to merge 4 commits intoSciTools:masterfrom
djkirkham:update_iris_112
Closed

Update iris recipe for Iris v1.12.0 release#244
djkirkham wants to merge 4 commits intoSciTools:masterfrom
djkirkham:update_iris_112

Conversation

@djkirkham
Copy link
Copy Markdown
Contributor

Based on #233 but set to skip OSX and Windows.

@lbdreyer @bjlittle

@djkirkham djkirkham changed the title Update iris 112 Update iris recipe for Iris v1.12.0 release. Mar 27, 2017
@djkirkham djkirkham changed the title Update iris recipe for Iris v1.12.0 release. Update iris recipe for Iris v1.12.0 release Mar 27, 2017
@DPeterK
Copy link
Copy Markdown
Member

DPeterK commented Mar 27, 2017

I'm sorry, this just isn't a good idea. While it's hypocritical for me to say this, going around skipping things because they don't work is not a solution, it's sweeping the problem under the rug. While it may get around the problem quickly in the short term all it is actually doing is adding to the growing pile of technical debt in the medium to long term.

These problems need to be fixed; why not make now the time to get the fixes in place?

Ironically though, this is an argument in favour of moving to conda-forge.

Comment thread iris/meta.yaml
number: 2
skip: True # [py35]
number: 0
skip: True # [py35 or osx or win]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need fixed OSX builds and Windows builds, not ignored ones...

Comment thread appveyor.yml
- cmd: conda list
- cmd: conda install --yes ruamel_yaml
- cmd: conda list
- cmd: conda install --yes --force python=3.5
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda-build-all needs to be updated to work with Py36. Force-downgrading python to Py35 introduces other problems into the builds.

@djkirkham djkirkham closed this Apr 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants