Skip to content

Conversation

@bjlittle
Copy link
Member

@bjlittle bjlittle commented May 2, 2018

This PR fixes the currently broken travis-ci tests.

I decided to flip back to unittest from pytest, simply because I couldn't get it to work using pytest (as it stood)

I also stopped travis-ci from pulling udunits2 from scitools 😱 , in preference from defaults. Moving to a more recent version of udunits2 i.e. 2.2.20 from scitools to 2.2.25 from anaconda highlighted that we had broken tests.

The tests were attempting to perform cross calendar datetime comparisions, which you can't do now (and I didn't know that you could ever do that)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 90.059% when pulling a37e791 on bjlittle:fix-travis-ci into f68303c on SciTools:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 90.059% when pulling a37e791 on bjlittle:fix-travis-ci into f68303c on SciTools:master.

@bjlittle
Copy link
Member Author

bjlittle commented May 2, 2018

Ping @pelson ... fancy reviewing this?

The travis-ci for cf-units needed some love... ❤️

@pelson pelson merged commit a6f3037 into SciTools:master May 2, 2018
@bjlittle bjlittle mentioned this pull request May 2, 2018
@bjlittle bjlittle deleted the fix-travis-ci branch May 3, 2018 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants