Skip to content

simplify config a bit#644

Merged
trexfeathers merged 1 commit intoSciTools:mainfrom
ocefpaf:simplify_test_yml
Jan 16, 2026
Merged

simplify config a bit#644
trexfeathers merged 1 commit intoSciTools:mainfrom
ocefpaf:simplify_test_yml

Conversation

@ocefpaf
Copy link
Member

@ocefpaf ocefpaf commented Jan 16, 2026

@trexfeathers this implements option 2 from #627 (comment)
It works locally, let's see if it works in the CI.

@scitools-templating: please no share prompt

@trexfeathers
Copy link
Collaborator

Templating thing is a work in progress 1 and not a concern. If everything else passes I will close-and-reopen and it should go away.

Footnotes

  1. our attempt to make it possible to manage 10 different repos between 8 different people without losing our sanity

Copy link
Collaborator

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, thanks. I had misunderstood and thought you weren't a fan of the idea.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (6857ee4) to head (41534fb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #644   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 16, 2026

Love this, thanks. I had misunderstood and thought you weren't a fan of the idea.

I have two minds on the src layout vs the flat layout. I prefer the latter for any pure Python project. I'm usually forced into the former when it is a compiled extension for many reasons, here it is the coverage functionality on Python 3.14. With all that said, it felt like walking in circles for simple tasks, so I was not in a hurry to implement. Until a simple solution* came to mind right as you were merging it 😬.

* Using a string in the cmd pixi config so we can do two commands instead of another node in the build command chain.

@trexfeathers trexfeathers merged commit 26f7831 into SciTools:main Jan 16, 2026
35 of 36 checks passed
@ocefpaf ocefpaf deleted the simplify_test_yml branch January 16, 2026 14:42
@trexfeathers
Copy link
Collaborator

I have two minds on the src layout vs the flat layout. I prefer the latter for any pure Python project.

I'm all for aligning with the community; it's easier than forming my own opinions! But we're in no hurry to do any directory re-organising.

@ocefpaf
Copy link
Member Author

ocefpaf commented Jan 16, 2026

I'm all for aligning with the community

Oh. The community is very divided on that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants