Conversation
|
@lbdreyer Test failure to investigate, but not your doing... 🤔 |
|
I think that test failure is just a method that shouldn't start with "test". cf-units/cf_units/tests/unit/unit/test_Unit.py Lines 82 to 94 in 2a164dc Edit: nope, that's just a warning I'm looking at. I'll open a PR to fix the warning anyway.... |
There was a problem hiding this comment.
@bjlittle not your doing
Not so sure.
I think the two files mentioned did get missed in updating the licence header.
So, I think these tweaks may fix what was wrong?
Haven't really checked anything else yet, but I'm sure it's right in spirit.
Co-authored-by: Patrick Peglar <patrick.peglar@metoffice.gov.uk>
|
Thanks for catching the problem @pp-mo ! The changes should now be correct |
pp-mo
left a comment
There was a problem hiding this comment.
Re-reviewing this to approve.
But I can't understand why this is necessary, since it lists no unresolved conversations.
Seen this before, I think it is possibly a GitHub bug ??
|
Thanks @pp-mo ! |
All the code in this repo comes from contributors who have now either signed the new CLA or are employees of the Met Office.
The new CLA enables us to relicense to BSD-3.
This PR: