Skip to content

Improve precommit config to apply fixes locally #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trexfeathers merged 3 commits into from
Jan 14, 2022
Merged

Improve precommit config to apply fixes locally #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
390502b
Remove --check
Jan 14, 2022
e468e39
lint -> precommit
Jan 14, 2022
2e69fd6
Run all hooks except no-commit-to-branch in CI
Jan 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,10 @@ task:
image: python:latest
cpu: 2
memory: 4G
name: "${CIRRUS_OS}: linting"
lint_script:
name: "${CIRRUS_OS}: precommit hooks"
precommit_script:
- python -m pip install --retries 3 pre-commit
- pre-commit run --all-files black
- pre-commit run --all-files flake8
- pre-commit run --all-files isort
- SKIP="no-commit-to-branch" pre-commit run --all-files


#
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ repos:
- id: black
# Force black to run on whole repo, using settings from pyproject.toml
pass_filenames: false
args: ["--config=./pyproject.toml", "--check", "."]
args: ["--config=./pyproject.toml", "."]
- repo: https://github.com/PyCQA/flake8
rev: "4.0.1"
hooks:
Expand All @@ -34,4 +34,4 @@ repos:
hooks:
- id: isort
name: isort
args: ["--filter-files", "--check"]
args: ["--filter-files"]