-
Notifications
You must be signed in to change notification settings - Fork 390
Add Lambert Equal Area Projection #619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @lbdreyer - this is a really good submission. |
lib/cartopy/crs.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to include "Azimuthal" as there is also a cylindrical alternative.
Are you sure this is the equal-area projection you are after? (It probably is.)
From a quick search around it looks OK as it is. |
lib/cartopy/crs.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The theoretical X axis limits are ±a * 2 + false_easting. But as with other projections it's best to reduce those limits a little to avoid problems at the boundary, e.g. (-a * 1.99999 + false_easting, a * 1.99999 + false_easting).
|
@lbdreyer - this looks good. I've also tested the docs when make_projection.py is run and it looks fine, so please go ahead and run that (it will update source/crs/projections.rst) as part of this PR. |
755eb2a to
bd74af1
Compare
b637a11 to
cbbae2d
Compare
508629e to
d539f0f
Compare
lib/cartopy/crs.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a period here.
|
👍 I'm happy to merge after you've squashed the commits. (Currently: bf3ad97) |
bf3ad97 to
c76ade9
Compare
Add Lambert Equal Area Projection
|
Thanks everyone 😄 |
|
👍 - awesome. Thanks @lbdreyer! |
|
Now we just need to get it released... 😉 |
This adds the lambert equal area projection.
Guidance with the x and y limits would be appreciated. The numbers I have used are temporary and just made the figure look about right.
I am also unclear as to whether there should be extra keywords e.g. scale factor.
(I have an implementation in Iris ready once this has merged.)