Skip to content

Conversation

@lbdreyer
Copy link
Member

This adds the lambert equal area projection.

Guidance with the x and y limits would be appreciated. The numbers I have used are temporary and just made the figure look about right.

I am also unclear as to whether there should be extra keywords e.g. scale factor.

(I have an implementation in Iris ready once this has merged.)

@rhattersley
Copy link
Member

Thanks @lbdreyer - this is a really good submission.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to include "Azimuthal" as there is also a cylindrical alternative.

Are you sure this is the equal-area projection you are after? (It probably is.)

@rhattersley
Copy link
Member

I am also unclear as to whether there should be extra keywords e.g. scale factor.

From a quick search around it looks OK as it is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The theoretical X axis limits are ±a * 2 + false_easting. But as with other projections it's best to reduce those limits a little to avoid problems at the boundary, e.g. (-a * 1.99999 + false_easting, a * 1.99999 + false_easting).

@pelson
Copy link
Member

pelson commented May 19, 2015

@lbdreyer - this looks good.
I just noticed you aren't on https://github.com/SciTools/cartopy/blob/master/docs/source/contributors.rst. Did you want to add yourself? (feel free to do it in this PR)

I've also tested the docs when make_projection.py is run and it looks fine, so please go ahead and run that (it will update source/crs/projections.rst) as part of this PR.

@lbdreyer lbdreyer force-pushed the lambert-equal-area branch 2 times, most recently from 755eb2a to bd74af1 Compare May 19, 2015 15:43
@lbdreyer lbdreyer force-pushed the lambert-equal-area branch 3 times, most recently from b637a11 to cbbae2d Compare July 27, 2015 13:36
@lbdreyer lbdreyer force-pushed the lambert-equal-area branch from 508629e to d539f0f Compare July 29, 2015 13:20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a period here.

@rhattersley
Copy link
Member

👍 I'm happy to merge after you've squashed the commits. (Currently: bf3ad97)

@lbdreyer lbdreyer force-pushed the lambert-equal-area branch from bf3ad97 to c76ade9 Compare August 3, 2015 13:10
rhattersley added a commit that referenced this pull request Aug 4, 2015
Add Lambert Equal Area Projection
@rhattersley rhattersley merged commit 3dd331f into SciTools:master Aug 4, 2015
@rhattersley
Copy link
Member

Thanks everyone 😄

@pelson
Copy link
Member

pelson commented Aug 4, 2015

👍 - awesome. Thanks @lbdreyer!

@rhattersley
Copy link
Member

Now we just need to get it released... 😉

@pelson pelson added this to the 0.14 milestone Aug 4, 2015
@QuLogic QuLogic modified the milestones: 0.14, 0.14.0 Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants