Skip to content

Allow CRS.transform_points() to work with float32. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pelson merged 1 commit into from
Oct 1, 2012
Merged

Allow CRS.transform_points() to work with float32. #58

pelson merged 1 commit into from
Oct 1, 2012

Conversation

@rhattersley
Copy link
Member

@rhattersley rhattersley commented Sep 28, 2012

No description provided.

@esc24
Copy link
Member

esc24 commented Sep 28, 2012

Looks good to me. I assume this will let me remove the astype(numpy.float64) from my coordinate arrays or is there a significant benefit to using the extra precision?

@rhattersley
Copy link
Member Author

rhattersley commented Sep 28, 2012

The underlying proj.4 routine always works with float64, so whatever values you supply to CRS.transform_points() they are cast to float64, transformed, and then returned as float64. So yes... where it's targeting CRS.transform_points() you'll be able to remove the calls to astype().

pelson
pelson reviewed Sep 28, 2012
View reviewed changes
lib/cartopy/mpl_integration/geoaxes.py
Copy link
Member

@pelson pelson Sep 28, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will these end up being used? If not, would you mind removing?

Copy link
Member Author

@rhattersley rhattersley Oct 1, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - not sure what you mean. I've already deleted those lines.

@pelson
Copy link
Member

pelson commented Sep 28, 2012

Looks good to me. Just a couple of questions (commented inline).

@rhattersley
Copy link
Member Author

rhattersley commented Oct 1, 2012

I think this is ready to merge.

@rhattersley rhattersley mentioned this pull request Oct 1, 2012
Closed
pelson added a commit that referenced this pull request Oct 1, 2012
@pelson
Merge pull request #58 from rhattersley/transform_float32
c02109a 
Allow CRS.transform_points() to work with float32.
@pelson pelson merged commit c02109a into SciTools:master Oct 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rhattersley @esc24 @pelson