Skip to content

Conversation

@greglucas
Copy link
Contributor

@greglucas greglucas commented Apr 4, 2024

This will still work with older numpy versions when running Cartopy built from a wheel with this build requirement.

This is what scipy has done to build their wheels.
https://github.com/scipy/scipy/blob/e2e39f691c048b8ad6dd5e7d4eb5a396a81f8dd3/pyproject.toml#L25-L31

I have tested this with numpy 1.25, and also the latest shapely and matplotlib nightlies and all tests passed locally.
pip install --upgrade --pre -i https://pypi.anaconda.org/scientific-python-nightly-wheels/simple shapely matplotlib

@greglucas greglucas added Type: Infrastructure CI: build wheels Run the release/wheel building on PR labels Apr 4, 2024
@greglucas greglucas added this to the Next Release milestone Apr 4, 2024
This will still work with older numpy versions when running
Cartopy built from a wheel with this build requirement.
@lgolston lgolston merged commit d5b19e2 into SciTools:main Apr 6, 2024
@lgolston lgolston requested review from lgolston and removed request for lgolston April 6, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: build wheels Run the release/wheel building on PR Type: Infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants