Bump minimum Proj to 8.0.0 #1854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
approved these changes
Sep 13, 2021
Contributor
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
We are in a weird in-between state right now. pyproj has wheels that it uses for the transform calculations now. But, we still need the PROJ library headers for the Geodesic stuff. That header file hasn't changed since PROJ4.9, so it is technically the latest version that is required. But, the version number we are referencing is from pyproj, so all of the test checks here will never hit those paths.
I think this is OK and we live with PROJ8.0 being our minimum, it will make it much easier to explain to everyone. Hopefully, we can completely remove the PROJ requirement in a release or two.
Otherwise we'll be mixing Python from defaults, which seems to pull in a few other things from defaults instead of conda-forge.
dopplershift
approved these changes
Sep 16, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
If I've understood #1808 correctly, we only support Proj 8+. This was changed in the documentation, but not actually in the coded requirements.
Implications
We can also drop a bunch of conditional code for old versions.