Use packaging.version instead of distutils #1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
reviewed
Sep 8, 2021
|
|
||
| if (hasattr(owslib, '__version__') and | ||
| LooseVersion(owslib.__version__) >= '0.19.2'): | ||
| parse_version(owslib.__version__) >= parse_version('0.19.2')): |
Contributor
There was a problem hiding this comment.
This is slightly annoying that we have to wrap everything ourselves now, rather than "parse_version" being able to cast the string to Version internally during the comparison...
greglucas
approved these changes
Sep 13, 2021
Contributor
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
This looks good to me. You have it as draft currently, feel free to self-merge if this is all you wanted to add here.
Member
Author
|
Just waiting for the minimum version bumps, which will cause a lot of conflicts for things that are dropped. |
greglucas
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Makes us prepared for Python 3.12, which removes
distutils.Fixes #1836.
Implications
New dependency.