-
Notifications
You must be signed in to change notification settings - Fork 6
Script to make PR authors aware if they are modifying templated files #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ESadek-MO
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really cool, seems to work really nicely and I haven't spotted anything worrying.
There's a couple of grammar type questions, but otherwise looks GTG.
Am I correct in thinking this will go in first, but won't be functional until actions on other repos are merged in?
trexfeathers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in thinking this will go in first, but won't be functional until actions on other repos are merged in?
Correct. The good news is that it is not dependent on future hypothetical code. Best way to think of it is 'ready to go', and we have even demonstrated what the future workflows will look like.
This has a few different permutations, plus I've made some minor changes to the existing
notify_updates()script, so I intend to produce some demonstrations of this all working before I take it out of draft.The demonstrations below use the
demo_templatingbranch. The only differences fromprompt-shareare those that enable demonstrations (see diff).notify_updates()The following issues were generated when the workflow ran against the same code used by this branch:
.pre-commit-config.yamlhas been updated trexfeathers/iris#91demo_1.pyhas been updated trexfeathers/cf-units#7Thus demonstrating that this PR does not break existing functionality
prompt_share()The new routine
Two demo pull requests
prompt-shareroutine trexfeathers/cf-units#8prompt-shareroutine trexfeathers/iris#92What these demonstrate
Proposal for actions on each repo
See these diffs, which introduce an identical new workflow on cf-units and iris (plus temporarily deleting the other workflows!)