This repository was archived by the owner on Jul 8, 2021. It is now read-only.
Ucubes and their summaries#26
Closed
pp-mo wants to merge 5 commits intoSciTools-incubator:masterfrom
Closed
Conversation
stickler-ci
reviewed
Oct 27, 2020
Member
Author
|
Hi @trexfeathers looking like you again 😀 It's not complete, but you may already have useful things to say... |
stickler-ci
reviewed
Oct 29, 2020
pp-mo
force-pushed
the
ucubes_summaries
branch
from
b4197c4 to
fe514e3
Compare
Member
Author
|
I'm going to close this + reopen another one because Stickler seems to be stuck. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
This is a heads-up for the intended changes to make unstructured cubes load as
UCubes (i.e. a specialised subclass),and then to make them print augmented cube summaries.
Along with SciTools/iris#3914, this effectively completes the import of SciTools/iris#3688 ,which was the POC code for this in the irtis "ng-vat" branch.
Unfinished business:
UCube._repr_html_ideally, should test that loading can (correctly) produce a mixture of UCube-s and Cube-s.( second thoughts : not very important. not going to bother )