Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't define Array#sum if already defined. Fixes #58 #65

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Don't define Array#sum if already defined. Fixes #58 #65

merged 1 commit into from
Oct 2, 2017

Conversation

rdlugosz
Copy link

Recent versions of ActiveSupport and Ruby 2.4.1 have added a #sum method
to the Enumerable class. Their implementation also accepts a block,
which the version included with StatSample does not.

This change tests to see if Array#sum is already defined before
patching.

This fixes issue #58 #58

Recent versions of ActiveSupport and Ruby 2.4.1 have added a #sum method
to the Enumerable class. Their implementation also accepts a block,
which the version included with StatSample does not.

This change tests to see if Array#sum is already defined before
patching.

This fixes issue #58 #58
@chooselife22
Copy link

Any progress on this?

@v0dro v0dro merged commit fd9a88d into SciRuby:master Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants