Made installation work with gpp10+ (version > 10) #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Duplicated of #632 |
|
hey, |
Hi,
or #632
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had to install nmatrix gem in a machine with gpp14 running and I noticed that the installation failed because was comparing the version as a string.
I fixed it making the function gplusplus version to return an array of numbers instead of a string, and changing the if conditions.
EDIT: I just noticed that there is already a Pull Requests solving this issue, but i think both PR can be merged since one fixes the find_newer_gplusplus method and another the conditionals checking the version.
fixes #630