Added NMatrix::IO::Matlab IO features with checking metadata about .m… #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at fie Issue_no::588
developerfab
reviewed
May 5, 2019
| require_relative '../../lib/nmatrix' | ||
|
|
||
| describe NMatrix::IO::Matlab do | ||
| def check_matrix_data_sparse arr |
There was a problem hiding this comment.
I think you could use shared_examples instead of define a method. what do you think? 🤔
| end | ||
| it "reads MATLAB .mat file containing a single square sparse matrix" do | ||
| pending("not yet implemented for NMatrix-JRuby") if jruby? | ||
| n = NMatrix::IO::Matlab.load_mat("spec/4x4_sparse.mat") |
There was a problem hiding this comment.
I have seen that you are using n = NMatrix::IO::Matlab.load_mat(...) in multiple test. Maybe you could use a let like:
let(:my_file) { "spec/4x4_sparse.mat" }
let(:n) { NMatrix::IO::Matlab.load_mat(my_file) }
it "reads MATLAB .mat file containing a single square sparse matrix" do
expect(n[0,0]).to eq(2)
...
end
...what do you think? 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a new file mat5_reader_spec.rb which not only check for validity of the elements stored in matrix ,but also checks for metadata related to .mat file.
regarding issue number #588