Fix C++ compiler selection #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://travis-ci.org/SciRuby/nmatrix/jobs/145353918 This failure isn't related to this pull-request. |
| @@ -107,6 +107,12 @@ def gplusplus_version | |||
| "#{major}.#{minor}.#{patch}" | |||
| end | |||
|
|
|||
| if CONFIG['CC'] == 'clang' && CONFIG['CXX'] != 'clang++' | |||
| puts "WARNING: CONFIG['CXX'] is not 'clang++' in spite of CONFIG['CC'] is 'clang'.", | |||
There was a problem hiding this comment.
Needs a grammar correction. "in spite of" -> "even though" or ", however"
|
These are all excellent changes. Just one minor tweak. Thanks for submitting them. |
|
@mrkn Just wanted to make sure you saw the comment above. |
mrkn
force-pushed
the
cxx_compiler_selection
branch
from
c283973
to
618f456
Compare
|
@MohawkJohn Fixed. |
mrkn
force-pushed
the
cxx_compiler_selection
branch
from
618f456
to
2dac1b6
Compare
|
And I've rebase onto the current master branch. |
|
Great work. Thanks so much! |
This was referenced Jul 22, 2016
This was referenced Jul 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: please merge #524 before this because this pull-request based on that pull-request.This pull-request allows us to select the collect combination of C++ and C compilers on OS X.
In Ruby < 2.4, configure script couldn't select the collect C++ compiler for the specified C compiler (I've fixed it on Ruby 2.4).
The changes in this is overwrite CXX variable to
clang++when CC isclang.#525 will be fixed by this.