Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby 2.5 and 2.6 to travis configuration #619

Open
translunar opened this issue Apr 9, 2018 · 7 comments
Open

Add Ruby 2.5 and 2.6 to travis configuration #619

translunar opened this issue Apr 9, 2018 · 7 comments

Comments

@translunar
Copy link
Member

From #617 it came to our attention that our Travis configuration is a bit out-of-date.

#610 is slightly different — this is correcting the existing configuration, which still needs to be done. But this issue, here, is just about adding 2.5 and 2.6 to the existing broken configuration.

@ngetahun
Copy link

Hey @MohawkJohn, is this issue still up for grabs? I'd like to make a PR.

@translunar
Copy link
Member Author

Yes, please! The Travis configuration is a mess. Take a swing!

@translunar
Copy link
Member Author

@ngetahun Did you end up having any luck?

@leesharma
Copy link

Hey there! It looks like this issue has been sitting for a few months—mind if I give it a go?

@translunar
Copy link
Member Author

translunar commented Oct 1, 2018 via email

@leesharma
Copy link

It looks like there's a compatibility issue between packable and ruby versions ≥ 2.5 (see SciRuby/packable#4). Because of this, tests that use their monkey-patched methods fail in CI for 2.5.1 and 2.6.0-preview2 (an example failure with the same error).

From the discussion on that issue, it looks like the problem isn't going to be resolved anytime soon. Luckily, the tests pass locally for me on OS X and Ubuntu; it looks like the problem is limited to CI and Debian systems. I think your options are:

  • Switch to a different library for packing/unpacking binary data,
  • Disable the broken functionality/tests on incompatible versions/systems, or
  • Delay this issue until they release a patched version.

How do you want to handle this?

@translunar
Copy link
Member Author

I'd say mark as pending on affected systems. It's difficult to extricate packable, but it's really only used in the Matlab IO, which should eventually become a plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants