Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make image/svg+xml a text type #301

Merged
merged 2 commits into from
May 27, 2021
Merged

Make image/svg+xml a text type #301

merged 2 commits into from
May 27, 2021
+17 −4

Conversation

kojix2
Copy link
Member

@kojix2 kojix2 commented May 27, 2021

Fix #300

@kojix2 kojix2 requested a review from mrkn May 27, 2021 11:35
@mrkn mrkn force-pushed the mime-type-svg branch from 13e0447 to 89f0678 Compare May 27, 2021 15:19
mrkn
mrkn approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@mrkn mrkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@mrkn mrkn merged commit adaa247 into SciRuby:master May 27, 2021
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 29, 2021
devel/ruby-iruby: update to 0.7.0
317241c 
0.7.0 (2021-05-28)

Enhancements
* The default backend is changed to IRB (@mrkn)
* Add IRuby::Kernel#switch_backend! method (@mrkn)

Bug Fixes
* Fix the handling of image/svg+xml
  SciRuby/iruby#300,
  SciRuby/iruby#301 (@kojix2)

0.6.1 (2021-05-26)

Bug Fixes
* Follow the messages and hooks orders during execute_request processing
  (@mrkn)

0.6.0 (2021-05-25)

Bug Fixes
* Fix the handling of application/javascript
  SciRuby/iruby#292,
  SciRuby/iruby#294 (@kylekyle, @mrkn)

Enhancements
* Add the initialized event in IRuby::Kernel class
  SciRuby/iruby#168,
  SciRuby/iruby#296 (@Yuki-Inoue, @mrkn)
* Add the following four events SciRuby/iruby#295
  (@mrkn):
  - pre-execute -- occurs before every code execution
  - pre-run-cell -- occurs before every non-silent code execution
  - post-execute -- occurs after every code execution
  - post-run-cell -- occurs after every non-silent code execution
* Replace Bond with IRB in PlainBackend
  SciRuby/iruby#276,
  SciRuby/iruby#297 (@cfis, @mrkn)
@kojix2 kojix2 deleted the mime-type-svg branch October 1, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrkn mrkn mrkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVG images do not show up
2 participants
@kojix2 @mrkn