Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve syntax error error message #251

Merged

Conversation

zheng-yongping
Copy link
Contributor

@zheng-yongping zheng-yongping commented Sep 17, 2019

before:
image
after:
image

There's another problem that needs to be fixed by fixing pry.
image

pry/pry#2080

@kojix2 kojix2 merged commit f494ef1 into SciRuby:master Oct 13, 2019
@kojix2
Copy link
Member

kojix2 commented Oct 13, 2019

HMM...
Honestly, I don't know if this change will work perfectly, but I think you are the most knowledgeable about this issue so I will merge. It's not good to leave the change half done.
If you have any new improvement, please send a pull request to fix them. 

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 4, 2021
0.5.0 (2021-03-25)

Bug Fixes:

  * Fix Jupyter console crashes issue
    SciRuby/iruby#210 (@kojix2)
  * Fix syntax highlighting issue on Jpyter Lab
    SciRuby/iruby#224 (@kojix2)
  * Fix interoperability issue with ruby-git
    SciRuby/iruby#139 (@habemus-papadum)
  * Fix the issue of `$stderr.write` that cannot handle multiple arguments
    SciRuby/iruby#206 (@kojix2)
  * Remove a buggy `inspect_request` implementation
    SciRuby/iruby#119 (@LunarLanding)
  * Fix uninitialized constant `Fiddle` caused in initialization phase
    SciRuby/iruby#264 (@MatthewSteen, @kjoix2)
  * Fix the issue on displaying a table
    SciRuby/iruby#281 (@ankane)

Enhancements:

  * Add `IRuby.clear_output` method
    SciRuby/iruby#220 (@kojix2)
  * Make backtrace on exception simplify and more appropriate for code in a
    cell SciRuby/iruby#249 (@zheng-yongping)
  * Make syntax error message more appropriate
    SciRuby/iruby#251 (@zheng-yongping)
  * Remove top-level `In` and `Out` constants
    SciRuby/iruby#229 (@kojix2)
  * Use text/plain for the default format of `Numo::NArray` objects
    SciRuby/iruby#255 (@kojix2)
  * Use ffi-rzmq as the default ZeroMQ adapter
    SciRuby/iruby#256 (@kojix2)
  * Drop rbczmq support SciRuby/iruby#260
    (@rstammer)
  * Add ruby-vips image support SciRuby/iruby#279
    (@ankane)
  * Replace mimemagic with mime-types
    SciRuby/iruby#291 (@mrkn)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants