-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes IO modules from Daru #430
Open
athityakumar
wants to merge
13
commits into
SciRuby:v-1-pre
Choose a base branch
from
athityakumar:remove-io-modules
base: v-1-pre
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
68016eb
Removes all IO methods and tests except save, load, to_html
athityakumar 79a3f8d
Removes unnecessary fixture files
athityakumar b716d51
Resolves merge conflict with origin:master
athityakumar ba318be
Shifts remaining marshal and save methods to dataframe, vector and index
athityakumar e130ab5
Removes require of daru/io/io.rb
athityakumar 9b62bfd
Merge branch 'v-1-pre' into remove-io-modules
athityakumar 1e2187c
Makes few changes to reduce rspec error
athityakumar a0224f5
Retains 2 csv files in spec/fixtures/ for tests
athityakumar d3762cb
Adds one final change for passing RSpec
athityakumar ea3f747
Removes Marshal methods
athityakumar f8e7c1f
Merges with origin/v-1-pre
athityakumar dafa586
Adds daru-io as runtime dependency of daru
athityakumar 37a1dc5
Reverts the dependency on daru-io (to be changed pre-release)
athityakumar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
source 'https://rubygems.org' | ||
gemspec | ||
gem 'daru-io', :git => 'https://github.com/athityakumar/daru-io.git' | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will
daru-io
be aruntime_dependency
ordevelopment_dependency
of daru?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runtime, of course. We need after
gem install daru
things likeDaru::DF.from_csv
to "just work".