Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to Kenneth-KT version of google visual r #169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Andrew-Max
Copy link

switch to Kenneth-KT version of google visual r because the old version is broken

References to other Issues or PRs

Fixes #168

Brief description of what is fixed or changed

switch to Kenneth-KT version of google visual r because the old version is broken

Testcase / documentation

switch to Kenneth-KT version of google visual r because the old version is broken

Other comments

Not sure how to test this. I believe this should address the issue though

@Andrew-Max
Copy link
Author

Verified that specs pass with new setup but unsure of how to do any further testing

@shekhar-rajak
Copy link

Hi, Thank you for working on it.

Rather than switching to new gem, would you like to check the changes and try out that change in the repo itself ?

@@ -36,7 +36,7 @@ Gem::Specification.new do |spec|
spec.add_development_dependency 'rubocop'

# fetching latest gem from the Gemfile
spec.add_runtime_dependency 'google_visualr'
spec.add_runtime_dependency 'google_visualr_rails5'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let us know the what change make it work. So that we get to know if we really need to switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on google_visualr 2.5.1 is broken
3 participants