Windows installation error fix #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts in single cell examples in dummy_iruby
Shekharrajak
force-pushed
the
windows-installation-iruby-notebook
branch
from
27e1985
to
5860f19
Compare
Pull Request Test Coverage Report for Build 791
💛 - Coveralls |
Closed
|
I will wait for few more hours and if I find no negative review, I will go ahead and merge it. |
|
@Shekharrajak |
|
I have cross verified in docker and windows system. It worked fine. I will release these changes soon. |
Shekharrajak
commented
Feb 25, 2019
| @@ -1,6 +1,7 @@ | |||
| require 'daru' | |||
| require 'securerandom' | |||
| require 'erb' | |||
| require 'daru/data_tables' | |||
There was a problem hiding this comment.
Need to check how tesstcases has written related to datatables (or may be not written). When I was running IRuby notebook and tried the adapter datatables it was not working.
After requiring the daru/data_tables it worked fine. Need to write testcase for it in separate PR.
This was referenced Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #144
Fixes #70
|-->-Rename *.ipynb files in dummy_iruby directory for Windows.
| (vertical bar) is not assigned to a directory or file in Windows 10.