Handling events in GoogleCharts #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 635
💛 - Coveralls |
|
@Shekharrajak can you please review this PR and let me know if there are any changes that I have to make? |
| js << "\n \t\toptions: #{js_parameters(@options)}," | ||
| js << "\n \t\tcontainerId: '#{element_id}'," | ||
| js << "\n \t\tview: #{extract_option_view}" | ||
| js << extract_chart_wrapper_options(data, element_id) |
There was a problem hiding this comment.
add_listeners_js('wrapper') in this method was generating rubocop error so I've created another method extract_chart_wrapper_options in the common module display.
|
Please write examples which can be useful in real world application. |
Prakriti-nith
force-pushed
the
listener_googlechart
branch
from
3de4278
to
454c58b
Compare
|
Right now, I have added these examples. |
spec/adapters/googlecharts_spec.rb
Outdated
| ) | ||
| } | ||
| let (:table_spreadsheet) { | ||
| Daru::View::Table.new( | ||
| data_spreadsheet, {width: 800} | ||
| ) | ||
| } | ||
| let(:data_table) {Daru::View::Table.new(data)} | ||
| let(:user_options) {{chart_class: 'Chartwrapper'}} |
There was a problem hiding this comment.
It would be better if you write new variables for new specs, rather than modifying existing variables completely.
|
@Shekharrajak can you please review this PR? |
Prakriti-nith
force-pushed
the
listener_googlechart
branch
from
6ede940
to
14ecc63
Compare
| sh "curl -# http://www.google.com/jsapi -L --compressed -o lib/daru/view/adapters/js/googlecharts_js/google_visualr.js" | ||
| end | ||
| end | ||
| # FIXME: Updating jsapi is causing error in IRuby notebook and Googlecharts do not work. |
There was a problem hiding this comment.
Open an issue to track this.
|
|
||
| task :loader do | ||
| say "Grabbing loader.js from the google website..." do | ||
| sh "curl -# http://www.gstatic.com/charts/loader.js -L --compressed -o lib/daru/view/adapters/js/googlecharts_js/loader.js" | ||
| end | ||
| end | ||
|
|
||
| task :jspdf do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this feature, a user can apply multiple listeners to a google chart/table to handle various events. I have added jspdf dependency for web frameworks because a user can at least use
readyevent to export the chart in pdf format. There are fewer examples provided on the official website. Examples.Event handling can be done in Highcharts easily through the highcharts options like this, so in googlecharts also, we are handling events through options (in third parameter).
Syntax:
Provide this in user_options (third parameter)