Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Action #954

Merged
merged 2 commits into from
Aug 23, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,23 @@ name: CI

on:
push:
branches:
- main
- '**/feature/*'
paths:
- 'py/**'
pull_request:
branches:
- main
paths:
- 'py/**'

jobs:
pre-commit:
runs-on: [ self-hosted, Linux ]
continue-on-error: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using continue-on-error: true may mask errors in the CI process. Consider removing it unless it's necessary for specific steps.

runs-on: arc-runner-set

steps:
- name: Checkout code
uses: actions/checkout@v3

- name: Run pre-commit
working-directory: ./py
run: |
python3 -m venv venv
source venv/bin/activate
Expand All @@ -39,7 +40,8 @@ jobs:
swap-storage: true

pytest:
runs-on: [ self-hosted, Linux ]
continue-on-error: true
runs-on: arc-runner-set
timeout-minutes: 15

env:
Expand All @@ -62,12 +64,12 @@ jobs:
curl -i http://localhost:11434

- name: Run pytest
working-directory: ./py
run: |
python3 -m venv venv
source venv/bin/activate
poetry install
pip install pytest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated pip install pytest command. Remove the redundant line to avoid unnecessary operations.

pip install pytest
poetry run pytest tests/ -k "not redis and not sentence_transformer"
deactivate
rm -rf venv
Expand Down
Loading