Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Analytics #931

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix Analytics #931

merged 1 commit into from
Aug 22, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Aug 22, 2024

🚀 This description was created by Ellipsis for commit 2fd9848

Summary:

Fixes analytics by restructuring filter_criteria and analysis_types handling in get_analytics_app and aanalytics functions.

Key points:

  • Updated get_analytics_app in py/core/main/api/routes/management/base.py to pass filter_criteria and analysis_types with correct structure.
  • Modified aanalytics in py/core/main/services/management_service.py to handle filter_criteria and analysis_types correctly.
  • Changed return structure of aanalytics to include analytics_data and filtered_logs.

Generated with ❤️ by ellipsis.dev

@NolanTrem NolanTrem merged commit f0618b1 into dev Aug 22, 2024
1 check failed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2fd9848 in 26 seconds

More details
  • Looked at 78 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_9mKzRgKtu2tvanci


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem deleted the Nolan/FixAnalytics branch August 22, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant