-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CLI Tests #912
Fix CLI Tests #912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to f84da73 in 21 seconds
More details
- Looked at
1220
lines of code in14
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_jRTgkS9DsGb7FQhQ
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
assert result.exit_code != 0 | ||
|
||
|
||
def test_documents_overview_with_document_id(runner, mock_r2r_client): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function test_documents_overview_with_document_id
is defined twice. Consider renaming or removing the duplicate function to avoid redundancy.
|
||
yield mock_client | ||
|
||
cli.callback = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset cli.callback
to original_callback
instead of None
to maintain consistency for other tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on e639c8a in 49 seconds
More details
- Looked at
305
lines of code in10
files - Skipped
0
files when reviewing. - Skipped posting
7
drafted comments based on config settings.
1. go/cli/rag_operations.go:51
- Draft comment:
Ensure that the flag name change fromdo-hybrid-search
touse-hybrid-search
is consistently applied across all files and references to avoid runtime errors. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment violates the rule of not asking the PR author to verify changes across all files, as it is speculative and not actionable within the context of the current diff. The change is consistent within the file, and the comment does not point out a specific issue within the diff itself.
I might be missing the possibility that the change could affect other parts of the codebase not shown in the diff, but the comment is still speculative and not actionable within the current context.
The comment is speculative and not actionable within the current diff, so it should be removed regardless of potential issues outside the diff.
Remove the comment as it is speculative and not actionable within the context of the current diff.
2. go/sdk/pkg/sdk/retrieval.go:42
- Draft comment:
Ensure that the flag name change fromdo_hybrid_search
touse_hybrid_search
is consistently applied across all files and references to avoid runtime errors. - Reason this comment was not posted:
Marked as duplicate.
3. js/sdk/README.md:98
- Draft comment:
Ensure that the flag name change fromdo_hybrid_search
touse_hybrid_search
is consistently applied across all files and references to avoid runtime errors. - Reason this comment was not posted:
Marked as duplicate.
4. js/sdk/src/models.tsx:40
- Draft comment:
Ensure that the flag name change fromdo_hybrid_search
touse_hybrid_search
is consistently applied across all files and references to avoid runtime errors. - Reason this comment was not posted:
Marked as duplicate.
5. py/cli/commands/retrieval.py:26
- Draft comment:
Ensure that the flag name change fromdo_hybrid_search
touse_hybrid_search
is consistently applied across all files and references to avoid runtime errors. - Reason this comment was not posted:
Marked as duplicate.
6. py/core/examples/hello_r2r.py:12
- Draft comment:
Ensure that the flag name change fromdo_hybrid_search
touse_hybrid_search
is consistently applied across all files and references to avoid runtime errors. - Reason this comment was not posted:
Marked as duplicate.
7. py/core/main/services/ingestion_service.py:107
- Draft comment:
Ensure that the flag name change fromdo_hybrid_search
touse_hybrid_search
is consistently applied across all files and references to avoid runtime errors. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_Ku6NDBRZkqupZHu1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Incremental review on 807988f in 22 seconds
More details
- Looked at
124
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. py/tests/cli/commands/test_restructure.py:50
- Draft comment:
The function nametest_enrich_graph
is not descriptive enough. Consider renaming it to something more specific, liketest_enrich_graph_execution
ortest_enrich_graph_time_taken
. - Reason this comment was not posted:
Confidence changes required:50%
The test function nametest_enrich_graph
is misleading because it doesn't specify what aspect of the graph enrichment is being tested. It should be more descriptive.
Workflow ID: wflow_ZvDIaoqzJjWzVLlk
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
assert result.exit_code != 0 | ||
|
||
|
||
def test_documents_overview_without_document_id(runner, mock_r2r_client): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function name test_documents_overview_without_document_id
is misleading as it actually tests the scenario with a document ID. Consider renaming it to test_documents_overview_with_document_id
.
* Fix CLI Tests (#912) Fix CLI tests * Shreyas/kg runtime cfg (#913) add kg runtime config * rename kgenrichmentresponse (#914) * revert change to chunking by_title --------- Co-authored-by: Nolan Tremelling <[email protected]> Co-authored-by: Shreyas Pimpalgaonkar <[email protected]>
* Feature/merge graphrag group mgmt (#876) * add group ids to document abstraction, first steps * extend group permissions * up * add tests for new group features * up * fixup auth * onboard extensive regression tests * adding regression tests * finish tests * rm selenium * test observability * uncomment tests * checkin first set of group tests * modify search, passing vector tests * checkin work * full delete logic * update search to use new filters * check in * Clean up * Check in * add search * tests/test_end_to_end.py::test_ingest_txt_document passing * cleanup logging * make schemas explicit * move to run logger abstraction * cleanup some test workflows * revive tests * tweak to pass tests * tweak rrf * finish hybrid search cleanup * fixup on regr tests, regen payloads * refresh payloads * refactor api model * Feature/refactor api model (#868) * cleanup imports * flake and cleanup * coherent global import / export structure * add ingestion response models * add management response models * cleanups * checkin work on routes * remove request models * last fixes * merge * add user / group gating * working test groups * updating client --------- Co-authored-by: NolanTrem <[email protected]> * Clean up API (#878) * Get running * fixes in sdk * Add in more fixes * Feature/merge dev owen changes (#880) * add group ids to document abstraction, first steps * extend group permissions * up * add tests for new group features * up * fixup auth * onboard extensive regression tests * adding regression tests * finish tests * rm selenium * test observability * uncomment tests * checkin first set of group tests * modify search, passing vector tests * checkin work * full delete logic * update search to use new filters * check in * Clean up * Check in * add search * tests/test_end_to_end.py::test_ingest_txt_document passing * cleanup logging * make schemas explicit * move to run logger abstraction * cleanup some test workflows * revive tests * tweak to pass tests * tweak rrf * finish hybrid search cleanup * fixup on regr tests, regen payloads * refresh payloads * refactor api model * Feature/refactor api model (#868) * cleanup imports * flake and cleanup * coherent global import / export structure * add ingestion response models * add management response models * cleanups * checkin work on routes * remove request models * last fixes * merge * add user / group gating * working test groups * updating client * rename service to restructure * add get documents for group endpoint * fix client bugs * return delete format * merge cleanups * merge * finalize --------- Co-authored-by: NolanTrem <[email protected]> * Shreyas/graphrag test (#881) * add group ids to document abstraction, first steps * extend group permissions * up * add tests for new group features * up * fixup auth * onboard extensive regression tests * adding regression tests * finish tests * rm selenium * test observability * uncomment tests * checkin first set of group tests * modify search, passing vector tests * checkin work * full delete logic * update search to use new filters * check in * Clean up * Check in * add search * tests/test_end_to_end.py::test_ingest_txt_document passing * cleanup logging * make schemas explicit * move to run logger abstraction * cleanup some test workflows * revive tests * tweak to pass tests * tweak rrf * finish hybrid search cleanup * fixup on regr tests, regen payloads * refresh payloads * refactor api model * Feature/refactor api model (#868) * cleanup imports * flake and cleanup * coherent global import / export structure * add ingestion response models * add management response models * cleanups * checkin work on routes * remove request models * last fixes * merge * add user / group gating * sync * enrich * up * fix global search * rag * remove client.py * rm configs * rm configs --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: NolanTrem <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]> * Feature/fix embedding pipe (#882) * up * fixup concurrency * fix ollama embeddings * fix batching with ollama * checkin all cleanups * rm kg cruft (#884) * rm kg cruft * tweaks * tweak 2 (#885) * Feature/fix retrieval endpoint cruft (#887) * tweak 2 * fix retrieval endpoint descriptions * Python SDK (#886) Clean up Python SDK and routes * Separate out SDK, add js and go sdk to monorepo (#888) * Add r2r-js sdk * Add go sdk * Pull out python sdk * remove venv * Update packages * Check in fixes * Remove alembic dependencies * Feature/merge w nolan (#894) * cleanup hybrid search * cleanups in * Fix structure * Make graspologic optional * fix rag stream (#895) * add py r2r (#896) * Clean up (#897) * fix agent (#898) * define `RAGAgentResponse` (#899) * Shreyas/unstructured (#900) * api + oss lib * rm pdb * rm poetry lock * update version * fixes * Feature/cleanup client obj logic (#901) * define `RAGAgentResponse` * cleanup client logic * Shreyas/tests (#889) * init * tests * rename service * api model * add * merge * rm restructure router * print descriptions * Refactor CLI (#903) * Rm files readded by git (#904) * Remove Execution Wrapper (#905) * Rm files readded by git * Fix merge botch * Feature/fix auth revive tests rebased (#906) * adding the client touch ups * fix auth, revive tests * add back tests * uncomment run auth workflow * decruft * refresh test kg * fixup toml (#908) * Feature/fix ingestion update (#909) * fixup toml * fix update * Fix CLI Tests (#912) Fix CLI tests * Shreyas/kg runtime cfg (#913) add kg runtime config * rename kgenrichmentresponse (#914) * Feature/add nltk hybrid expansion rebased (#917) * expand hybrid search with nltk * cleanups * cleanup hybrid search * format * add setup.py * update * add script (#918) * Fix bug in document chunks (#921) * Fix bug in update files (#923) * Shreyas/unstructured (#922) * fix dockerfiles * adding config * fix paths * mv unstructured dep to docker * clean * Update docker_utils.py * Update unstructured_parsing.py * Update r2r_chunking.py * Update app_entry.py * Feature/repair logging (#925) * fixing logs * fix * rm double logging (#929) * Configs (#926) * Fix config logic * Update config * Clean up cli entry point * Disable SSL when installing nltk wordnet (#930) * Fix analytics endpoint * Update OpenAI sdk calls (#933) * Feature/revive advanced rag (#932) * rm double logging * revive advanced rag examples * merge (#934) * sync model (#935) * Feature/remove version from ingestion end pt (#936) * sync model * remove ability to set version * tweak versions impl * fix version bug * Move docker (#938) * Move docker * remove from root * Clean up sdk/restructure.py * Fix js tests, completion scoring (#939) * Shreyas/unstructured docker image (#940) unstructured docker image * Update JS (#941) * Update models (#942) * Feature/complete group logic (#945) * fix group logic * up * Fix Dockerbuild, Symlink Readme (#944) * Add back tast prompt override and include title if availible * Fix docker, sym link readme * Fix compose file path * Shreyas/KG Search Result model (#937) * return type to kg_search_result * add model * local and global results * modify config * refresh should not be gated by auth (#946) * Linting sync (#947) * Remove email from refresh (#948) * Fix link to image * Feature/rm print cruft rebase (#953) * refresh should not be gated by auth * rm print cruft * black and sort * merge * rm * update api return type * Update Actions (#954) * Update Github Actions (#956) * Update Actions * Update actions * Shreyas/kgsearchresult model (#957) * return type to kg_search_result * add model * local and global results * modify config * add models * up * fix config path * fix models * Login and refresh token bug (#959) * Update Actions * Fix bug in login with refresh token * Point pytest to linux (#960) * collection docs (#955) * Feature/merge dev to main (#962) * merge dev and main * git rm * add back collection fix * fix docker builds (#963) * Running unstructured docker + code cleanups (#964) * Small bugfixes on prompts, return types (#965) * Fix failing CLI tests * NPM publish action * remove tarball * Feature/fix dev tests (#966) * update auth tests * fix tests * back and sort * decruft * revert back to gpt-4o --------- Co-authored-by: NolanTrem <[email protected]> Co-authored-by: Shreyas Pimpalgaonkar <[email protected]>
Summary:
This PR fixes CLI tests, renames a flag, and enhances test coverage, improving robustness and handling of
None
values.Key points:
do-hybrid-search
touse-hybrid-search
inpy/cli/commands/retrieval.py
and other files.None
values inJsonParamType.convert
.py/core/examples/hello_r2r.py
for consistent output formatting.Generated with ❤️ by ellipsis.dev