Feature/add unstructured docker #824
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 01cba3e in 56 seconds
More details
- Looked at
164lines of code in4files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_uqtEeugTORq19AQZ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| gcc g++ musl-dev curl libffi-dev gfortran libopenblas-dev \ | ||
| tesseract-ocr libtesseract-dev libleptonica-dev pkg-config \ | ||
| poppler-utils libmagic1 \ |
There was a problem hiding this comment.
The poppler-utils package is installed twice, once in the builder stage and once in the final image. Consider removing it from the builder stage to optimize the build process.
|
|
||
| # Install system dependencies (including those needed for Unstructured and OpenCV) | ||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| gcc g++ musl-dev curl libffi-dev gfortran libopenblas-dev \ |
There was a problem hiding this comment.
The curl package is installed twice, once in the builder stage and once in the final image. Consider removing it from the builder stage to optimize the build process.
| gcc g++ musl-dev curl libffi-dev gfortran libopenblas-dev \ | ||
| tesseract-ocr libtesseract-dev libleptonica-dev pkg-config \ | ||
| poppler-utils libmagic1 \ | ||
| libgl1-mesa-glx libglib2.0-0 \ |
There was a problem hiding this comment.
The libgl1-mesa-glx and libglib2.0-0 packages are installed twice, once in the builder stage and once in the final image. Consider removing them from the builder stage to optimize the build process.
| # Install system dependencies (including those needed for Unstructured and OpenCV) | ||
| RUN apt-get update && apt-get install -y --no-install-recommends \ | ||
| gcc g++ musl-dev curl libffi-dev gfortran libopenblas-dev \ | ||
| tesseract-ocr libtesseract-dev libleptonica-dev pkg-config \ |
There was a problem hiding this comment.
The tesseract-ocr package is installed twice, once in the builder stage and once in the final image. Consider removing it from the builder stage to optimize the build process.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 5e73e8e in 38 seconds
More details
- Looked at
45lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_D8JeqLeLKitd5lXf
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| if isinstance(data, bytes): | ||
| data = BytesIO(data) | ||
|
|
||
| # TODO - Include check on excluded parsers here. |
There was a problem hiding this comment.
The TODO comment suggests adding a check for excluded parsers, which is not implemented. This is crucial for ensuring that the parsing process respects the configuration settings to exclude certain parsers.
| # TODO - Include check on excluded parsers here. | |
| # Implement the check for excluded parsers as indicated by the TODO. |
Summary:
Add Dockerfile for 'unstructured' parsing provider, update dependencies, enhance 'UnstructuredParsingProvider' class, and update tests.
Key points:
Dockerfile.unstructuredto build a Docker image with 'unstructured' parsing provider.pyproject.tomlto includepoppler-utilsdependency.r2r.tomlto set parsing provider to 'unstructured'.r2r/providers/parsing/unstructured_parsing.pyto yieldExtractionobjects and log parsing details.tests/test_config.pyto reflect changes in configuration.Generated with ❤️ by ellipsis.dev