Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/finalize assistant workflows #774

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jul 26, 2024

🚀 This description was created by Ellipsis for commit f9b4a9e

Summary:

Finalized assistant workflows by renaming classes, adding RAG chat functionality, and updating methods across multiple files for consistency and new capabilities.

Key points:

  • Renamed RAGAssistant to R2RRAGAssistant and StreamingRAGAssistant to R2RStreamingRAGAssistant in r2r/assistants/__init__.py.
  • Updated R2RAssistant and R2RStreamingAssistant classes in r2r/assistants/base.py to handle new workflows and added sync_wrapper for synchronous execution.
  • Introduced RAGAssistantMixin for shared functionality in r2r/assistants/rag.py.
  • Added rag_chat method in r2r/main/api/client.py for RAG chat functionality.
  • Updated RetrievalRouter in r2r/main/api/routes/retrieval/base.py to include /rag_chat endpoint.
  • Modified Assistant, Tool, and Conversation classes in r2r/base/abstractions/assistant.py for better handling of messages and tools.
  • Updated KGSearchSettings in r2r/base/abstractions/search.py to rename agent_generation_config to kg_search_generation_config.
  • Updated R2RBuilder and R2RAssistantFactory in r2r/main/assembly to use new assistant classes.
  • Enhanced RetrievalService in r2r/main/services/retrieval_service.py to support RAG chat.
  • Updated KGSearchSearchPipe in r2r/pipes/retrieval/kg_search_search_pipe.py to use new kg_search_generation_config.

Generated with ❤️ by ellipsis.dev

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review July 26, 2024 17:36
@emrgnt-cmplxty emrgnt-cmplxty merged commit a8a423b into dev Jul 26, 2024
1 of 3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f9b4a9e in 1 minute and 10 seconds

More details
  • Looked at 1310 lines of code in 19 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. r2r/assistants/base.py:110
  • Draft comment:
    The sync_wrapper function is called immediately when defining the wrapper function, which could lead to premature execution of the asynchronous generator. Consider modifying the implementation to ensure that the generator is only executed within the intended context.
+        return sync_wrapper(
+            self.arun(system_instruction, messages, *args, **kwargs)
+        )
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_okNvItdrKaooTVwc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty deleted the feature/finalize-assistant-workflows branch July 30, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant