Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/fix hyde pipelines #746

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Patch/fix hyde pipelines #746

merged 2 commits into from
Jul 22, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Jul 22, 2024

🚀 This description was created by Ellipsis for commit 1ecab37

Summary:

Update version and fix parameter name in r2r/pipes/retrieval/query_transform_pipe.py.

Key points:

  • Update version in pyproject.toml from 0.2.67 to 0.2.68.
  • Fix parameter name in r2r/pipes/retrieval/query_transform_pipe.py _run_logic method.
  • Change system_task_name to task_prompt_name in _run_logic method.

Generated with ❤️ by ellipsis.dev

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review July 22, 2024 21:35
@emrgnt-cmplxty emrgnt-cmplxty merged commit bcb92b3 into main Jul 22, 2024
3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 1ecab37 in 20.588425 seconds

More details
  • Looked at 28 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. r2r/pipes/retrieval/query_transform_pipe.py:65
  • Draft comment:
    The change from system_task_name to task_prompt_name aligns with the expected method signature in PromptProvider, ensuring proper functionality.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR changes the parameter name from system_task_name to task_prompt_name in the _get_message_payload method call. This change is consistent with the method definition in the PromptProvider class, which expects task_prompt_name as a parameter. This is a necessary correction to align with the expected method signature and ensure the code functions correctly.

Workflow ID: wflow_IN668Qyq8rgsXXjH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty deleted the patch/fix-hyde-pipelines branch July 23, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant