Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mooncake to Alternative AD Frontends #1151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

willtebbutt
Copy link

@willtebbutt willtebbutt commented Nov 19, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Follow up PR from SciML/DiffEqBase.jl#1103

I've put the rules needed for this to work in src/tmp_mooncake_rules.jl for the sake of debugging. Once we're happy that this is basically good, I'll move this over to an extension in DiffEqBase.

There are currently a few tests which are broken that I don't believe ought to be broken, which I can work on fixing.

It would be helpful to have feedback on whether I've extended the test suite in the right way etc, and to know which bits of the docs I should update (if any).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant