Make the chunksize determination static when static #1540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
force-pushed
the
static_chunksize
branch
from
0fc3154
to
5769734
Compare
5 tasks
chriselrod
reviewed
Jan 25, 2022
| end | ||
| end | ||
|
|
||
| @generated function pick_static_chunksize(::Val{chunksize}) where chunksize | ||
| x = ForwardDiff.pickchunksize(chunksize) | ||
| :(Val{$x}()) |
There was a problem hiding this comment.
FWIW, Pumas has been relying on const prop for this, and that seems to be fine so far.
There was a problem hiding this comment.
IIRC it caused a major performance change here 😅
There was a problem hiding this comment.
I should double check Pumas, then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bit more of a sane version of #1536