-
-
Notifications
You must be signed in to change notification settings - Fork 58
Add trim tests (rebased)
#734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChrisRackauckas
merged 23 commits into
SciML:master
from
ChrisRackauckas-Claude:add-trim-tests-rebased
Nov 14, 2025
Merged
Add trim tests (rebased)
#734
ChrisRackauckas
merged 23 commits into
SciML:master
from
ChrisRackauckas-Claude:add-trim-tests-rebased
Nov 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduce `SafeTestsets` as part of this, inspired by the way the downstream tests are set up in the `SciMLBase` repo.
See TrimTest.jl comment for rationale.
The rational in code comment.
[skip ci]
Problem was solved in SciML/LinearSolve.jl#724, although SciML/LinearSolve.jl#648 just got reopened.
still segfault... [skip ci]
b23aa76 to
ae6b600
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of PR #665 onto the latest master.
Summary
Add a
trimdirectory with basic tests for trimming, imitating the code/package loading structure of SciMLBase.Changes
test/trim/juliacfor Julia 1.12+OncePerProcessversions for better trimming supportTest Structure
The tests verify:
juliac --trimNotes
test/trim/to avoid conflictsOriginal PR: #665
Original Author: @RomeoV
🤖 Generated with Claude Code