Handle subtractions and use MacroTools #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devmotion
commented
Jul 15, 2018
| else | ||
| ex.args[2:end] | ||
| :($(Meta.quot(Base.muladd))($x, $y, $z)) | ||
| end |
There was a problem hiding this comment.
I'm not sure why quoting is needed here and whether that's the correct way to handle the application of @. macros. But it was the only way I could get it to work besides expanding @. macros immediately which in my opinion should not be required (or at least feels a bit suboptimal).
|
Wow, that is much simpler. I am enjoying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest PR some days ago reminded me that I wanted to resolve #5 quite some time ago. Finally I took the time and came up with a rewritten implementation using MacroTools which handles subtractions as well. Hopefully the use of MacroTools can improve both the readability and further development of this package.