Create invalidations.yml

[ranocha]

This is based on https://github.com/julia-actions/julia-invalidations. Adding such checks came up in https://discourse.julialang.org/t/potential-performance-regressions-in-julia-1-8-for-special-un-precompiled-type-dispatches-and-how-to-fix-them/86359. I suggest to add this check here since this package is widely used as a dependency.

[devmotion]

Hmm, I don't think it's useful in this package? It's very very stable, so it's very unlikely to be changed significantly, it has no dependencies, and it does not overload any existing function in base.

[ranocha]

I would ague the other way round: If this package is so stable, Ci will basically never run, so it's not a problem to include this setup. On the other hand, if this package introduced invalidations for some reason, we would probably want to know about it.

[devmotion]

But why include something if it's never run? 😅 It's also still unclear to me how one could introduce any invalidations in this package.

So my impression is that probably it is much much more relevant to check for invalidations in other (probably also SciML) packages.

[ranocha]

Does it cost anything to include it? If not, why shouldn't we include it?

[devmotion]

It will run every time a simple PR (such as #27, a docstring update, or some reformatting) is opened, I don't think that's useful.

[ChrisRackauckas]

This cost is the least of our problems. I'll always trade CI time to decrease human time.

[devmotion]

Fair enough. I'm still curious though, @ranocha, why you opened this PR to MuladdMacro instead of more active packages that implement methods from base and are also more difficult/impossible to check manually such as SciMLBase, DiffEqBase, OrdinaryDiffEq etc.? Did you see any problems with MuladdMacro that we should fix?

[ranocha]

I didn't only do it for MudallMacro.jl but also for other packages such as Static.jl. I think we should get started with the most baseline packages and then extend it step by step to higher-level packages.
I did this since I spend two days hunting and fixing invalidations, which is definitely not fun.

[ranocha]

For example, OrdinaryDiffEq.jl pulls in so many packages that we should get started with all of these dependencies first, I think.

[ChrisRackauckas]

I think someone should just do a mass PR to all of SciML adding this. There's some tool for doing mass PRs like that, and I'd accept it (though please add [ci skip] if that's done 😅)

[ranocha]

Are the main branches all master in SciML or do some have main, others master?

[ChrisRackauckas]

A few of the newer ones probably have main 😅

[ranocha]

https://github.com/julia-actions/MassInstallAction.jl does not seem to have an option for this. Are we okay with checking the main branch by hand? Or shall I try to find something else?

[ChrisRackauckas]

Yeah that sounds fine.

[ranocha]

Looks like they also have no simple way of editing the commit message to include [ci skip]. Let me have a look at it

[ChrisRackauckas]

Well today I'm flying, so there's no better day to slam CI anyways 😅.

[ranocha]

Yeah, but MassInstallAction.jl does not work right now (on Julia v1.8), see julia-actions/MassInstallAction.jl#57

[ChrisRackauckas]

Ouch.

[ranocha]

Okay, fixed locally (and submitted PRs). I will run

wget https://raw.githubusercontent.com/SciML/MuladdMacro.jl/master/.github/workflows/invalidations.yml
export MY_GITHUB_TOKEN=""
julia

julia> using Pkg; Pkg.activate(temp=true); Pkg.develop("MassInstallAction"); using MassInstallAction

julia> workflow = MassInstallAction.Workflow("Invalidations", "invalidations.yml" => read("invalidations.yml", String))

julia> MassInstallAction.install(workflow,
                                 "SciML";
                                 token = ENV["MY_GITHUB_TOKEN"],
                                 cc = ["ranocha", "ChrisRackauckas"],
                                 commit_message = "MassInstallAction: Install the Invalidations workflow on this repository (automated commit made by MassInstallAction.jl) [ci skip]",
                                 pkg_url_type = :ssh)

Okay?

[ChrisRackauckas]

That sounds great.

[ranocha]

I get something like

[massinstallaction/set-up-Invalidations c862fdc] MassInstallAction: Install the Invalidations workflow on this repository (automated commit made by MassInstallAction.jl) [ci skip]
 1 file changed, 33 insertions(+)
 create mode 100644 .github/workflows/invalidations.yml
ERROR: Permission to SciML/DEDataArrays.jl.git denied to ranocha.
fatal: Could not read from remote repository.

for quite a few packages. I guess someone with more rights needs to repeat this. I used my branch https://github.com/ranocha/MassInstallAction.jl/tree/hr/tmp of MassInstallAction.jl for this, bundling my recent PRs to this package.

[devmotion]

It seems the PRs don't skip CI?

[ranocha]

I included [ci skip] in the commit messages - what else can we do?

I tested it before for my own repos, e.g.,

• MassInstallAction: Install the Invalidations workflow on this repository ranocha/SummationByPartsOperators.jl#146
• MassInstallAction: Install the Invalidations workflow on this repository ranocha/BSeries.jl#75

There, all GitHub actions CI were skipped.

[devmotion]

It seems it's actually only a problem with some of the buildkite pipeline configurations. Eg in DiffEqBase buildkite was run (but nothing else it seems?) since it is only skipped if the commit message (?) includes [skip tests]: https://github.com/SciML/DiffEqBase.jl/blob/master/.buildkite/pipeline.yml Not sure if that setup is intentional.

[devmotion]

Same in OrdinaryDiffEq, so probably should include [skip tests] next time. Not sure if that also would skip Github actions, or if it is needed in addition.