-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop MacroTools dependency #15
Conversation
|
||
[deps] | ||
MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09" | ||
version = "0.2.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last release was 0.2.1
so this is good to tag once this is merged
Do you mean this implementation of |
I was mostly being facecious, because its a 2 line function so how can one do it "better". |
Yes, I agree that your implementation is definitely easier to understand 👍 |
@ChrisRackauckas, can you merge the PR? I don't have write access. |
oh you don't? I thought you did. |
I was also surprised 😛 |
Its not worth depending on MacroTools and thus anything it depends on (DataStructures & OrderedCollections)
For this simple function.
I also think this implementation of the function is better,