[v10] refactor: use ImplicitDiscreteSystem to implement affects in callback systems #3452
Closed
[v10] refactor: use ImplicitDiscreteSystem to implement affects in callback systems #3452
ImplicitDiscreteSystem to implement affects in callback systems #3452Conversation
vyudu
force-pushed
the
callback
branch
2 times, most recently
from
4a6f2f6 to
b7997b0
Compare
isaacsas
reviewed
Mar 21, 2025
isaacsas
reviewed
Mar 26, 2025
vyudu
changed the title
ImplicitDiscreteSystem to implement affects in callback systems ImplicitDiscreteSystem to implement affects in callback systems
Member
Author
|
@ChrisRackauckas @AayushSabharwal This is very close, just needs a release for ImplicitDiscreteSolve and getting all the doc blocks working. One of the FMI tests is failing because the reinitialization isn't accurate enough (like 1.008e-8 but the tolerance is 1e-8), but I am unsure if that is related. |
vyudu
changed the title
ImplicitDiscreteSystem to implement affects in callback systems ImplicitDiscreteSystem to implement affects in callback systems
vyudu
force-pushed
the
callback
branch
2 times, most recently
from
dfcd812 to
ed947b7
Compare
Member
Author
|
@AayushSabharwal I think this is basically ready to merge into the v10 branch. The FMI failure is the thing we discussed where the initialization fails with some error very close to the tolerance; the other test failures seem unrelated |
Member
Author
AayushSabharwal
requested changes
Apr 26, 2025
Member
AayushSabharwal
left a comment
AayushSabharwal
left a comment
There was a problem hiding this comment.
There are significant performance regressions in this PR.
vyudu
force-pushed
the
callback
branch
2 times, most recently
from
7debb1d to
a63853a
Compare
Co-authored-by: Aayush Sabharwal <aayush.sabharwal@gmail.com>
Co-authored-by: Aayush Sabharwal <aayush.sabharwal@gmail.com>
Member
|
Tests aren't passing |
vyudu
force-pushed
the
callback
branch
2 times, most recently
from
3756f2b to
426e6bb
Compare
AayushSabharwal
force-pushed
the
v10
branch
2 times, most recently
from
95eb9e4 to
d16bd28
Compare
Member
|
Superseded by #3614 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #2639 #2612