Use AbstractSparseMatrixCSC for sparse factorizations #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #273 +/- ##
===========================================
- Coverage 70.97% 35.86% -35.12%
===========================================
Files 14 11 -3
Lines 858 764 -94
===========================================
- Hits 609 274 -335
- Misses 249 490 +241
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
|
Anywhere that assumes it's a sparsematrixcsc should not remove the conversion because that could concrete things like MatrixOperators of SparseMatrixCSC. For things that are already concrete matrices it should be a no-op so that's fine, and then afterwards it should assert it's an AbstractSparseMatrixCSC and use the sparse matrix functions on it. |
ChrisRackauckas
approved these changes
Feb 20, 2023
Contributor
Author
|
👍 |
Contributor
Author
|
Hi,I think we need a version update for LinearSolvePardiso.jl as well to bring this in place there. |
Member
|
It should probably be changed into an extension package in the near future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This e.g. would allow to supply a matrix type with multithreaded factorization etc. Would solve #190.
However, see JuliaSparse/SparseArrays.jl#265 .