Skip to content
This repository has been archived by the owner on Jun 11, 2022. It is now read-only.

use dirname(@__FILE__) instead of Pkg.dir #1

Merged
merged 1 commit into from
Oct 27, 2016
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Oct 27, 2016

so the package can be installed elsewhere

so the package can be installed elsewhere
@ChrisRackauckas ChrisRackauckas merged commit 23e78db into master Oct 27, 2016
@ChrisRackauckas
Copy link
Member

Okay. I remember you mentioned this before. Thanks.

@ChrisRackauckas ChrisRackauckas deleted the tk/nopkgdir branch October 27, 2016 03:19
@tkelman
Copy link
Contributor Author

tkelman commented Oct 27, 2016

And you're missing JLD from REQUIRE, and using JLD for this file

@ChrisRackauckas
Copy link
Member

Last time I checked, if one does using JLD these commands work because it's looking for JLD in Main.

@tkelman
Copy link
Contributor Author

tkelman commented Oct 27, 2016

I wouldn't rely on that. JuliaLang/julia#17997

If it's a test-only dependency then it at least needs to be listed in test/REQUIRE

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants