Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state dependent delay citation #184

Merged
merged 3 commits into from
Jun 15, 2020
Merged

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@devmotion
Copy link
Member

Seems some upstream change broke type inference.

Regarding the citations, I noticed that our approach here is somewhat similar to https://link.springer.com/article/10.1007/s11075-009-9331-y. Maybe it should be mentioned as well?

@devmotion
Copy link
Member

I assume the test errors are caused by some of the latest changes in DiffEqBase, probably the ones in init_call SciML/DiffEqBase.jl@v6.37.0...v6.38.3 (6.37.0 worked fine some days ago but 6.38.3 errors).

@ChrisRackauckas
Copy link
Member Author

Yes, the possibility of a logger can break inference. JuliaLang/julia#35976 is really what's needed to do all of this properly.

@devmotion
Copy link
Member

Maybe then let's just mark all the inference tests as broken for now (and not only for a subset of algorithms)?

@ChrisRackauckas
Copy link
Member Author

Indeed that's my plan. What's going on is that type inference couldn't propagate static information through keyword argument splats, so anything that can change a type from a keyword argument causes an instability. So progress does it all of the time, but even before, you'd get an instability because of save_idxs=1 changing the solution type. But since it's all in constant type information, in theory Julia could figure it out, and that PR fixes the flow of this information on Julia v1.6. So since it's not the biggest deal for performance (though it is annoying), I think it's best to just know that inference is not going to do well until v1.6, at which point everything should always infer.

@ChrisRackauckas
Copy link
Member Author

(and note: there's a push to have it in v1.5, and it should be discussed in the next triage meeting)

@devmotion devmotion merged commit 4e6c916 into master Jun 15, 2020
@devmotion devmotion deleted the ChrisRackauckas-patch-2 branch June 15, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants